Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revise crate doc for rand_pcg, rand_chacha #1454

Merged
merged 8 commits into from
May 23, 2024
Merged

Revise crate doc for rand_pcg, rand_chacha #1454

merged 8 commits into from
May 23, 2024

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented May 22, 2024 •
edited
Loading

Closes #1347.

Examples involding rand are avoided, partly for brevity and partly because we can't test them (dev-dependencies on rand work for testing, but cause issues with releases).

I'm also looking at revising the rand::rngs module doc, but I'll post a new PR.

@dhardy dhardy requested a review from newpavlov May 22, 2024 11:41
newpavlov
newpavlov approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we at it, I think it's worth to re-export rand_core from each RNG crate.

.github/workflows/test.yml Outdated Show resolved Hide resolved
rand_chacha/src/lib.rs Outdated Show resolved Hide resolved
rand_chacha/src/lib.rs Outdated Show resolved Hide resolved
rand_chacha/Cargo.toml Outdated Show resolved Hide resolved
rand_pcg/Cargo.toml Outdated Show resolved Hide resolved
rand_pcg/src/lib.rs Outdated Show resolved Hide resolved
newpavlov
newpavlov reviewed May 22, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
rand_chacha/Cargo.toml Outdated Show resolved Hide resolved
@dhardy dhardy merged commit defeb0c into master May 23, 2024
14 checks passed
@dhardy dhardy deleted the work1 branch May 23, 2024 06:21
@dhardy dhardy mentioned this pull request May 23, 2024
Merged
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rand_pcg has zero usage examples
2 participants
@dhardy @newpavlov