-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make getrandom a non-pub dep; rename feature to os_rng #1537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think getrandom::Error
can be still exposed in the public API of rand_core
. I don't think it's worth to wrap it in a custom type at this stage.
I disagree: It is possible to add a method like For now I'm not sure it's worth bothering with this however. |
I am fine with wrapping the error, it's just that I don't see much merit in it since it's unlikely that API of |
Pretty much all the changes I've been planning are already in Yes, there's #1261, but if any of that lands it's more likely to be in v2.0 or later. Much of it depends on future Rust features. |
CHANGELOG.md
entryRemove
getrandom
from the public API so that upgrading the version used will be non-breaking.Rename the feature
getrandom
toos_rng
. This is in line withsmall_rng
,std_rng
, and its effect of enablingOsRng
,from_os_rng
andrand::rng
.