Use 'dest' as name for bytes param #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
reviewed
May 15, 2018
src/rngs/thread.rs
Outdated
| @@ -112,7 +112,7 @@ impl RngCore for ThreadRng { | |||
| unsafe { (*self.rng.get()).next_u64() } | |||
| } | |||
|
|
|||
| fn fill_bytes(&mut self, bytes: &mut [u8]) { | |||
| fn fill_bytes(&mut self, dest: &mut [u8]) { | |||
| unsafe { (*self.rng.get()).fill_bytes(bytes) } | |||
There was a problem hiding this comment.
One more line to change...
There was a problem hiding this comment.
Sorry, I ran tests on Master because apparently today is Monday. :)
There was a problem hiding this comment.
Is it? Well, second time lucky 😄
Other implementations of RngCore appear to consistently use "dest" as the name for this parameter.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other implementations of RngCore appear to consistently use "dest" as the name for this parameter. I have submitted this PR because RLS uses this name for autocomplete, which can result in mild annoyance when it doesn't match as anticipated.