Skip to content

Switch documentation to rust-random.github.io and prepare 0.6.1 #652

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 23, 2018

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Nov 22, 2018

This is based on top of the commit in #651 so only one of these needs to be merged.

Possible solution to #646.

@dhardy dhardy merged commit 73613ff into rust-random:master Nov 23, 2018
@dhardy
Copy link
Member Author

dhardy commented Nov 23, 2018

Lets try this tweak to shields and doc. If it doesn't go down well we can always revert the change.

@dhardy dhardy deleted the doc branch November 23, 2018 10:42
@newpavlov
Copy link
Member

Looks like a fine temporary solution, but personally I would prefer if docs.rs will be used if possible. Is there any good solutions for cross-crate links which will work with docs.rs?

@dhardy
Copy link
Member Author

dhardy commented Nov 23, 2018

Well, absolute links work. Otherwise maybe we can fudge it with deeper relative links? For example ../../../../rand_pcg/*/rand_pcg/type.Pcg32.html from here might work... though it'll probably break local builds and what we host on github.io.

Or maybe we can use a script to fix things up... could be ugly.

There's also the html_root_url parameter modified here, but I don't know if that helps us.

@dhardy
Copy link
Member Author

dhardy commented Nov 23, 2018

Found an issue I created six months ago: rust-lang/docs.rs#204

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants