Make rand compile with nightly

[fhahn]

When compiling rand with the current nightly it fails because Rustc cannot find the correct type for the second operand of the wrapping shift operation:

src/isaac.rs:134:37: 134:48 error: the type of this value must be known in this context
src/isaac.rs:134             ($x:expr) => ( self.mem[($x >> 2).0 as usize & (RAND_SIZE_USIZE - 1)] )
src/isaac.rs:373:42: 373:53 error: the type of this value must be known in this context
 src/isaac.rs:373                 *self.mem.get_unchecked((($x >> 3).0 as usize) & (RAND_SIZE_64 - 1))

This PR adds an explicit cast to usize to fix this, but this may be a regression worth reporting upstream?

[tomjakubowski]

👍 for reporting this upstream (I would do it but I don't know enough about this particular regression).

[numerodix]

Same as #92

[fhahn]

@numerodix 👍 you were a little bit faster. I'll close my PR.

It's already reported upstream

[brson]

I filed the regression in Rust. We should probably fix that.

[brson]

@fhahn Oh, you said it was reported upstream. Do you have a link?

[erickt]

@brson: I think it's rust-lang/rust#30713.

[brson]

rust-lang/rust#30733 should fix this

[sfackler]

Can we merge this thing? New nightlies have not landed for the last couple of days, and I believe this is blocking getting serde in a good place. cc @erickt

[steveklabnik]

It was fixed in Rust a few hours ago, so tomorrow it should build without the patch. At least, that's what I thought.

On Jan 7, 2016, 13:21 -0500, Steven Facklernotifications@github.com, wrote:

Can we merge this thing? New nightlies have not landed for the last couple of days, and I believe this is blocking getting serde in a good place. cc@erickt(https://github.com/erickt)

—
Reply to this email directly orview it on GitHub(#93 (comment)).

[andrew-d]

👍 on merging anyway - fixing rustc is obviously the best way to go about this, but having builds be broken in the mean time has been somewhat frustrating.

[Manishearth]

The nightlies are broken so this still isn't fixed. Could someone merge and publish this? A lot of crates are broken because of this.

cc @alexcrichton

[alexcrichton]

Looks like #92 beat this to the bunch, so closing, but thanks!

[steveklabnik]

The linux dist bot timed out :(

On Sat, Jan 9, 2016 at 12:58 PM, Alex Crichton notifications@github.com
wrote:

Closed #93 #93.

—
Reply to this email directly or view it on GitHub
#93 (comment).