Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added function get_enabled to export vring enable status. #291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WeiChungHsu
Copy link

Summary of the PR

The vring is disabled and RX/TX queue is set to
not-ready during snapshot. But vhost-device process
keeps access vring and queue after snapshot which
caused system hang. We need to export vring enabled
and disabled status for snapshot feature so that
the vhost-device would skip vring/queue access
after snapshot to avoid hang.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

The vring is disabled and RX/TX queue is set to
not-ready during snapshot. But vhost-device process
keeps access vring and queue after snapshot which
caused system hang. We need to export vring enabled
and disabled status for snapshot feature so that
the vhost-device would skip vring/queue access
aftr snapshot to avoid hang.

Signed-off-by: Wei-Chung Hsu <weihsu@google.com>
@stefano-garzarella
Copy link
Member

@WeiChungHsu why closing #284 in favor of this? What are the differences?

Please in the future avoid that, it's better to continue on the same PR to check the history of reviews, etc.

@WeiChungHsu
Copy link
Author

@WeiChungHsu why closing #284 in favor of this? What are the differences?

Please in the future avoid that, it's better to continue on the same PR to check the history of reviews, etc.

Sorry, I tried many git commands, but can't rebase this PR on current main. In addition, I accidentally close the old PR. Sorry about that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants