Implement ByteValued for i128/u128 #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
force-pushed
the
byte-valued-128
branch
2 times, most recently
from
674baa4 to
e39f487
Compare
jiangliu
approved these changes
Jun 26, 2023
The only interesting thing in this commit is adjusting the unit test that tests these implementations, as u128/i128 can be aligned to 8 byte boundaries on x86. So only check that reading fails for values misaligned by 1 through 7 bytes. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
jiangliu
force-pushed
the
byte-valued-128
branch
from
e39f487 to
aaa5d97
Compare
|
superseded by #242 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Implements
ByteValuedfor u128/i128, as well as arrays of them.I also looked at turning the array implementations into one using const generics (to remove the restriction on them being only implemented for array sizes up to 32), but a combination of
Defaultbeing a super trait ofByteValuedand rust-lang/rust#61415 make this impossibleRequirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.