Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve documentation for UIKit and AppKit handles #160

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Feb 22, 2024

This takes part of the main thread only docs from #154, but with the less strong guarantee of the handle only ever existing on the main thread (as that's probably not yet true in the wild, so I'd rather have consumers to the extra check).

@madsmtm madsmtm added the documentation Improvements or additions to documentation label Feb 22, 2024
@madsmtm madsmtm force-pushed the apple-handles-documentation branch from aee40b9 to 51582c2 Compare February 22, 2024 16:33
@Lokathor
Copy link
Contributor

Other than the wasm CI failing, which I think is unrelated, it's always good to have usage example docs.

@madsmtm
Copy link
Member Author

madsmtm commented Feb 22, 2024

wasm CI failing

Yeah, Winit had the same problem, not sure how cargo hack works so don't know how to fix it, so I'm just gonna merge it regardless.

@Lokathor
Copy link
Contributor

Do we have a "wasm expert" to call for things like this? If
not, should we move the wasm jobs to a separate CI path and just let them fail when they fail?

@madsmtm
Copy link
Member Author

madsmtm commented Feb 22, 2024

That would be @daxpedda

@madsmtm madsmtm merged commit 5e5dbed into master Feb 22, 2024
3 of 4 checks passed
@madsmtm madsmtm deleted the apple-handles-documentation branch February 22, 2024 21:29
@daxpedda
Copy link
Member

There is no good fix for this, this is a Cargo problem: rust-lang/rfcs#3537.

The best we can do here, which we have done in Winit as well, is pin the bumpalo version in CI:
https://github.com/rust-windowing/winit/blob/a127bd6f6684909852000cdf32469bac3b611887/.github/workflows/ci.yml#L92

@notgull notgull mentioned this pull request Apr 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants