Rework documentation for Surface::set_buffer
#57
Conversation
| /// G: Green channel | ||
| /// B: Blue channel | ||
| /// ``` | ||
| /// fn pixel(red: u8, green: u8, blue: u8) -> u32 { |
There was a problem hiding this comment.
Excellent addition to have this pre-made example function. I'm not sure if this is the right place for it. Perhaps it should be in an example instead, or just callable as a pub fn in softbuffer. I think that this is ultimately the best place for it, but I'm not certain so I wanted to call attention to this choice.
There was a problem hiding this comment.
The utility of this function being publicly accessible is probably quite low as it is extremely generic. Plus this may change eventually if other pixel formats are supported.
i509VCB
force-pushed
the
doc-set-buffer-update
branch
from
b89520f to
f320021
Compare
This includes a more clear description of the pixel format expected.
raw-window-handle 0.5.1 requires 1.64, so we have no real choice here.
i509VCB
force-pushed
the
doc-set-buffer-update
branch
from
af8a30e to
8e85b8d
Compare
|
Wait what, why does github only allow me to request one reviewer but not multiple... |
i509VCB
changed the title
GraphicsContext::set_bufferSurface::set_buffer
|
@i509VCB I will accept this PR if it is rebased and rewritten to apply to the |
This includes a more clear description of the pixel format expected.