-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
On Windows, fix undecorated shadow reported client size is bigger than what's visible #3712
base: master
Are you sure you want to change the base?
On Windows, fix undecorated shadow reported client size is bigger than what's visible #3712
Conversation
6d8873e
to
4caf694
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to reproduce this? Using the base example on the master
branch, I don't see this on Windows 11.
(Looks good otherwise)
I have added an example in this PR that can be used to test this, just checkout this PR and revert the changes made to I am also using Windows 11, the issue seems to happen only when undecorated shadows are active. |
@notgull this should be ready now, thanks to implementation of the folks at GPUI, I tested different combination of decorations and undecorated shadows and all work as expected. I tested the implementation with winit and wry as well. I have included an example in this PR that creates a window with a border on the reported surface size which can be used to compare with master branch. |
This PR also has a good side effect that makes undecorated windows with shadows have native resize handles without explicitly handling Undecorated windows with shadows are unaffected, would still need manual hittesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if @notgull has the time to review this? If not, then I'd be fine with merging it myself (will do so in 2 weeks if John hasn't answered before then, @amrbashir please ping me if I forget).
@madsmtm just a friendly remineder 😅 |
changelog
module if knowledge of this change could be valuable to usersHere is before:

And here is after:
