Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement "compress" and lzw writer #100

Merged
merged 6 commits into from
May 20, 2024

Conversation

rishadbaniya
Copy link
Contributor

at this point the "compress" utility works as required(except for the force flag), integration test is missing, which needs to be added and few code cleanups i guess :)

@rishadbaniya rishadbaniya marked this pull request as draft May 18, 2024 16:32
@rishadbaniya
Copy link
Contributor Author

@jgarzik now compress is ready to be used completely :)

@rishadbaniya rishadbaniya marked this pull request as ready for review May 19, 2024 17:03
@jgarzik jgarzik merged commit 0a1f191 into rustcoreutils:main May 20, 2024
2 checks passed
@jgarzik
Copy link
Contributor

jgarzik commented May 20, 2024

This unfortunately adds several new compile warnings, which is unwanted. posixutils should build warning-free.

@rishadbaniya
Copy link
Contributor Author

i'm really sorry for that @jgarzik, will make sure such mistakes dont happen next time

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants