Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause here is that this test should be deleting
t
and not the deeply nested sub-directory under it.The error is because Rust's implementation of
remove_dir_all
is doing recursion which doesn't close the directory handles until it reaches the deepest subdir. The implementation ofrm
can deletet
because it opens only one handle so it won't get the "Too many open files" error. It does comes with the tradeoff of having to cache the visited files though.