Skip to content

Update to security-framework 2.2.0 #23

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

seanpianka
Copy link

@seanpianka seanpianka commented May 15, 2021

Update a core-foundation dependency via the latest version of security
framework.

Edit: This PR should fix issues with generating code coverage with crates
using rustls-native-certs, see rust-lang/rust#63047 (comment) for more details.

Signed-off-by: Sean Pianka pianka@eml.cc

@seanpianka
Copy link
Author

seanpianka commented May 16, 2021

I see that rustls 0.19.1 does not include the upgrade to webpki 0.22, so I think this PR is blocked on a new release of rustls that includes the DnsRefName changes.

@djc
Copy link
Member

djc commented Oct 11, 2021

Hi, I'm wondering: why is it important to update the security-framework version here, given that 2.2.0 is semver-compatible with the 2.0.0 we currently depend on? (If you still think it's important, would you mind rebasing this?)

@seanpianka
Copy link
Author

Hi @djc, thanks for the response. There's nothing left to be done here, as you're right that the semvar-compatibility already allows for implicitly what I'm changing explicitly.

This PR stemmed from this original issue which caused errors when profiling code built on macOS. I think it's now safe to say that this issue did not stem from rustls-native-certs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants