Cleanup RE #320 #340
Merged
Cleanup RE #320 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es more consistent
rustprooflabs
added a commit
that referenced
this pull request
Jun 11, 2023
* Add shop tests (#338) Add tests for shop point/polygon counts. Includes moving test docs to main docs page, and overall improvements to the examples. * Change "all" views to tables loaded via Flex style (#337) * Changing vbuilding_all view to building_combined_point table * Create PK, move helper into style folder * Starting to convert vshop_all. Current version has test errors due to moving code into shop_helper. Need to add more tests on original to help find the cause of the problem with this change. * Fix loading of shop polygons. Reset shop_polygon test output to actual. * Add detailed POI tests * Restructure POI loading in prep to migrate all view * Moving from vpoi_all mat view to poi_combined_point table * still failing on poi_combined_point * Fixed import problem by setting up ID column properly * Cleanup RE #320 (#340) * Remove refresh of MV that no longer exists. Make comments on new tables more consistent * Add missing comments. Install PgDD extension
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove refresh of MV that no longer exists. Make comments on new tables more consistent. Fill in missing comments.
Install PgDD extension in Docker image. Makes
CREATE EXTENSION pgdd;available, helpful when looking through comments on database objects.