-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
v0.13.0 breaks existing NextJS build due to main vs. module change: #1402
Comments
This seems related to this change in v0.13.0:
|
can confirm this change is causing some issues on our end (the change of declared module type), is there a way to select the type of the output package ? |
mkeeter
added a commit
to mkeeter/fidget
that referenced
this issue
Dec 16, 2024
Using [`wasm-bindgen-rayon`](https://github.com/RReverser/wasm-bindgen-rayon/), we can render with the global Rayon thread pool (instead of hand-rolling a tile-based renderer). This is significantly faster! Unfortunately, as part of the Web Ecosystem™, everything is janky and fragile. The code includes workarounds for the following issues: - rustwasm/wasm-pack#1402 (`wasm-pack` changed things, breaking Webpack) - rustwasm/wasm-bindgen#4233 (`wasm-bindgen` fixed what they believe to be a bug, breaking `wasm-bindgen-rayon` in the process)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
🐛 Bug description
When building using
v0.13.0
vs.v0.12.1
, our existing NextJS/wasm-pack build process will break within CI with an opaque error message.🤔 Expected Behavior
It should continue to work?
👟 Steps to reproduce
Use a
package.json
that looks like this, then try to use an NPM package build withwasm-pack 0.13.0
with this:package.json
tsconfig.json
🌍 Your environment
Include the relevant details of your environment.
wasm-pack version:
0.13.0
rustc version:
rustc 1.79.0-nightly (385fa9d84 2024-04-04)
npm version:
18.17.0
The text was updated successfully, but these errors were encountered: