Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(#1076): --target-dir as extra option is now considered as expected #1082

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix(#1076): --target-dir as extra option is now considered as expected #1082

merged 1 commit into from
Dec 14, 2022

Conversation

sassman
Copy link
Contributor

@sassman sassman commented Nov 17, 2021

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@wdanilo
Copy link

wdanilo commented Dec 13, 2022

@drager - do you think we can merge it? It would save a lot of debugging on our end this week :(

@drager
Copy link
Member

drager commented Dec 14, 2022

@drager - do you think we can merge it? It would save a lot of debugging on our end this week :(

Yes! I'll try to publish a new release this week as well.

drager
drager approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@drager drager merged commit 9f909db into rustwasm:master Dec 14, 2022
@wdanilo
Copy link

wdanilo commented Dec 15, 2022

Thanks so so so much @drager !

@drager drager mentioned this pull request Mar 19, 2023
Closed
@wdanilo wdanilo mentioned this pull request Feb 6, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@drager drager drager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sassman @wdanilo @drager