Make Deno target available #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egfx-notifications
force-pushed
the
feature/support-deno-target
branch
from
068d788 to
e084101
Compare
|
Rebased my changes onto v0.10.2 as af8eb33 broke the tests in master. |
|
Have to wait for #1118 to be resolved in order to get the tests to succeed. |
|
Thank you for making the effort and continuing the work on adding deno support! |
egfx-notifications
force-pushed
the
feature/support-deno-target
branch
from
e084101 to
dee3614
Compare
|
Should be ready for merge now that !1119 was merged |
Merged
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submittingThis PR makes Deno available since
wasm-bindgendoes support it as a target now.This PR continues the work done in #908. I decided to push the discussed changes here as a separate PR as the original PR creator did not seem to be working on this anymore.
Related PR
#908
Related issues
#672
#879