Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add suppot for more platforms to installer script #1122

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

omninonsense
Copy link
Contributor

@omninonsense omninonsense commented Mar 16, 2022

This makes the installation script work on M1 macs, as well as inside docker (especially when combined with buildx) for aarch64/arm64 architectures.

Related:

@gthb
Copy link
Contributor

gthb commented Mar 16, 2022

There's a bunch of open issues about M1 support, should this be marked as closing some of them? https://github.com/rustwasm/wasm-pack/issues?q=is%3Aissue+is%3Aopen+m1

@omninonsense
Copy link
Contributor Author

omninonsense commented Mar 16, 2022

Hi! Thanks for taking a look at this. It might help with #1064; I'll update the description

@omninonsense
Copy link
Contributor Author

Seems to fail for unrelated reasons

@omninonsense
Copy link
Contributor Author

Hi, @gthb, are you the right person to look into merging this, or do we just wait for it to get picked up by the maintainers?

@gthb
Copy link
Contributor

gthb commented Mar 24, 2022

Hi, @gthb, are you the right person to look into merging this, or do we just wait for it to get picked up by the maintainers?

I think only @drager has the admin bit, or at least is the only one who has been acting on some PRs in recent months.

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drager drager merged commit da5a409 into rustwasm:master Jun 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants