Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Linux arm64 support #1170

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add Linux arm64 support #1170

merged 1 commit into from
Sep 1, 2022

Conversation

nnelgxorz
Copy link
Contributor

Adds support for Linux arm64 in the wasm-pack npm package.

Fixes: #1169

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@nnelgxorz nnelgxorz mentioned this pull request Aug 27, 2022
Closed
@nnelgxorz
Copy link
Contributor Author

Hmm. Doesn't seem like the test failures are related to the PR changes.

@manucorporat
Copy link

Hope this gets merged soon

drager
drager approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the tests are unrelated. Thanks for the effort, will merge it!

@drager drager merged commit 10f30be into rustwasm:master Sep 1, 2022
@zanettin
Copy link

Hi @drager 👋
Any estimations on when this fix gets released? 👼 Thanks in advance 🙏

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@drager drager drager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux arm64 is unsupported in the npm package.
4 participants
@nnelgxorz @manucorporat @zanettin @drager