Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update dependencies #1292

Merged
merged 4 commits into from
Jun 11, 2023
Merged

Update dependencies #1292

merged 4 commits into from
Jun 11, 2023

Conversation

ranile
Copy link
Contributor

@ranile ranile commented May 30, 2023

Updates:

  • Clap
  • toml
  • predicates
  • serial_test

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@ranile
Copy link
Contributor Author

ranile commented Jun 1, 2023

I ran the failing tests locally and they pass, not sure what's happening in the CI

@drager
Copy link
Member

drager commented Jun 8, 2023

@hamza1311 Tests have been fixed in master now. Could you perhaps rebase master into your branch?

@ranile
Copy link
Contributor Author

ranile commented Jun 10, 2023

@drager done

drager
drager approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drager drager merged commit fc59a26 into rustwasm:master Jun 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@drager drager drager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranile @drager