Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use new chromdriver endpoint #1325

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

Myriad-Dreamin
Copy link
Contributor

Make sure these boxes are checked! πŸ“¦βœ…

  • You have the latest version of rustfmt installed
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ πŸ˜„ Thanks so much for contributing to wasm-pack! πŸ˜„ ✨✨

fix #1315.

I have tested it on my windows11 x86 pc, but not tested on macOS machines since I don't have one.

New endpoint changes target mac64 to mac-x64

    let target = if target::LINUX && target::x86_64 {
        "linux64"
    } else if target::MACOS && target::x86_64 {
        "mac-x64" // here!
    } else if target::MACOS && target::aarch64 {
        "mac-arm64"
    }

And that new endpoint provides chromedriver for mac-arm64:

    let target = if target::LINUX && target::x86_64 {
        "linux64"
    } else if target::MACOS && target::x86_64 {
        "mac-x64"
    } else if target::MACOS && target::aarch64 {
        "mac-arm64" // here!
    }

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@drager drager merged commit 8cba32f into rustwasm:master Nov 17, 2023
@tamird
Copy link

tamird commented Dec 19, 2023

Would it be possible to cut a new release with this?

@drager
Copy link
Member

drager commented Jul 1, 2024

Would it be possible to cut a new release with this?

Released in v0.13.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromedriver download using outdated endpoints.
3 participants