Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: optimize out-dir display (close: #1395) #1396

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

ahaoboy
Copy link
Contributor

@ahaoboy ahaoboy commented May 29, 2024

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

close: #1395

wasm-pack build --out-dir=../fib-wasm/wasm

Optimize out-dir display, from

[INFO]: 📦   Your wasm pkg is ready to publish at /root/code/fib-wasm/fib-rs/../fib-wasm/wasm.

to

[INFO]: 📦   Your wasm pkg is ready to publish at /root/code/fib-wasm/fib-wasm/wasm.

I'm not sure if the clean function needs to be called in other places where the display function is called, it seems that just optimizing the display of out-dir is enough

@ahaoboy
Copy link
Contributor Author

ahaoboy commented May 29, 2024

ci failed, #1390 #1391 #1371

@ahaoboy ahaoboy force-pushed the master branch 2 times, most recently from 85104fc to fbc556c Compare May 30, 2024 06:37
@drager
Copy link
Member

drager commented Jun 25, 2024

I just merged #1391. Can you rebase master into this branch? :)

@ahaoboy
Copy link
Contributor Author

ahaoboy commented Jun 26, 2024

I just merged #1391. Can you rebase master into this branch? :)

The test still fails, I don't know if it is related to this PR

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drager drager merged commit abe080f into rustwasm:master Jun 26, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the display of the path
2 participants