Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Build crate in a workspace #430

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Build crate in a workspace #430

merged 2 commits into from
Nov 6, 2018

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Nov 5, 2018

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed and have your
    cloned directory set to nightly
$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran rustfmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@fitzgen fitzgen added this to the 0.6.0 milestone Nov 5, 2018
@alexcrichton
Copy link
Contributor

r=me, but looks like rustfmt on CI disagrees with your local rustfmt?

@fitzgen
Copy link
Member Author

fitzgen commented Nov 5, 2018

Huh. I did a rustup and still I'm not getting any more diffs... I wonder if Travis is using an old Rust??

@alexcrichton
Copy link
Contributor

Stable vs nightly perhaps?

@fitzgen
Copy link
Member Author

fitzgen commented Nov 5, 2018

I just double checked that our CI config was using nightly (and did #432 at the same time) and confirmed that yes it is. And I am also using nightly...

@fitzgen
Copy link
Member Author

fitzgen commented Nov 5, 2018

Added some logging of the rustfmt version to #432

@fitzgen
Copy link
Member Author

fitzgen commented Nov 5, 2018

Looks like I am using an out-of-date rustfmt!

Mine:

$ cargo fmt --version
rustfmt 0.99.5-nightly (90692a5 2018-09-26)

Theirs:

$ cargo fmt --version
rustfmt 0.99.6-nightly (750b252 2018-10-18)

But I can't update mine further...

$ rustup update
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'beta-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2018-11-05, rust version 1.32.0-nightly (e6c5cf923 2018-11-04)
error: component 'clippy-preview' for 'x86_64-unknown-linux-gnu' is unavailable for download
info: checking for self-updates

       stable-x86_64-unknown-linux-gnu unchanged - rustc 1.30.0 (da5f414c2 2018-10-24)
         beta-x86_64-unknown-linux-gnu unchanged - rustc 1.31.0-beta.4 (04da282bb 2018-11-01)
  nightly-x86_64-unknown-linux-gnu update failed - rustc 1.31.0-nightly (2bd5993ca 2018-10-02)

$ cargo fmt --version
rustfmt 0.99.5-nightly (90692a5 2018-09-26)

@fitzgen
Copy link
Member Author

fitzgen commented Nov 5, 2018

Huh, looks like it was clippy holding me back

error: component 'clippy-preview' for 'x86_64-unknown-linux-gnu' is unavailable for download

@fitzgen fitzgen force-pushed the build-crate-in-a-workspace branch 2 times, most recently from 2d141d6 to 1f799dc Compare November 5, 2018 23:53
@fitzgen fitzgen force-pushed the build-crate-in-a-workspace branch from 1f799dc to 8abedfe Compare November 6, 2018 01:03
@alexcrichton alexcrichton merged commit e8b3075 into rustwasm:master Nov 6, 2018
@alexcrichton alexcrichton mentioned this pull request Nov 6, 2018
Closed
@fitzgen fitzgen deleted the build-crate-in-a-workspace branch November 6, 2018 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@ashleygwilliams ashleygwilliams Awaiting requested review from ashleygwilliams

Assignees
No one assigned
Labels
changelog - feature
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fitzgen @alexcrichton @ashleygwilliams