Arbitrary alignment #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This threads the requested alignment through all the allocation functions, and makes them take the requested alignment into account. Size classes are not used for alignments greater than the size of a word, since that means we wouldn't be able to pack their memory like `[header, data, header, data, ...]`. Instead, we would need to introduce padding like `[header, padding, data, header, padding, data, ...]`. Fixes #29
This should help exercise the alignment code paths.
The CI issues we have been hitting are fixed in binaryen master.
fitzgen
commented
Mar 5, 2018
.travis.yml
Outdated
| @@ -25,7 +25,7 @@ before_script: | |||
| - which cargo-readme || cargo install cargo-readme | |||
| - test -d binaryen || git clone https://github.com/WebAssembly/binaryen.git | |||
| - export PATH="$PATH:$(pwd)/binaryen/bin" | |||
| - which wasm-opt || (cd binaryen && cmake . && make -j4 && cd -) | |||
| - which wasm-opt || (cd binaryen && git pull origin master && cmake . && make -j4 && cd -) | |||
There was a problem hiding this comment.
Hrm... this didn't seem to do the trick.
Merged
fitzgen
force-pushed
the
arbitrary-alignment
branch
from
e4137ff to
1046396
Compare
|
Ok, just made |
|
Thanks for review! 😸 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #29; see each commit for details.