Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

set require cxx 17 on, or there is error: 'optional': is not a member #475

Closed
wants to merge 3 commits into from

Conversation

guanshaoheng
Copy link
Contributor

while compiling on windows, std::optional is required

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (140d3ad) to head (e19193b).
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
+ Coverage   97.23%   98.20%   +0.97%     
==========================================
  Files          10       10              
  Lines         217      223       +6     
==========================================
+ Hits          211      219       +8     
+ Misses          6        4       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guanshaoheng guanshaoheng deleted the cxx17_required branch January 14, 2025 23:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants