Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fontconfig file does not include regular Fira Code variant #918

Closed
3 tasks done
Scrumplex opened this issue Sep 7, 2022 · 6 comments
Closed
3 tasks done

Fontconfig file does not include regular Fira Code variant #918

Scrumplex opened this issue Sep 7, 2022 · 6 comments

Comments

@Scrumplex
Copy link

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
Since v2.2, the fontconfig file in the root of this repo doesn't include configuration for Fira Code (or Fira Code Regular).

<alias>
<family>Fira Code,Fira Code SemiBold</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>
<alias>
<family>Fira Code,Fira Code Medium</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>
<alias>
<family>Fira Code,Fira Code Light</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>
<alias>
<family>Fira Code,Fira Code Retina</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>

Expected behavior:
Prior to v2.2, the fontconfig file in the root of this repo included configuration for Fira Code (or Fira Code Regular).

<alias>
<family>Fira Code</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>
<alias>
<family>Fira Code,Fira Code Medium</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>
<alias>
<family>Fira Code,Fira Code Retina</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>
<alias>
<family>Fira Code,Fira Code Light</family>
<prefer><family>Symbols Nerd Font</family></prefer>
</alias>

Example symbols:
N/A

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • FiraCode-Regular.ttf (unpatched Fira Code)
    • Symbols-2048-em Nerd Font Complete.ttf (From AUR package, v2.2)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    • kitty
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • Linux

★ Screenshots (Optional)

N/A

Finii added a commit that referenced this issue Sep 8, 2022
[why]
Some (the most basic) Families are not added.

[how]
The used shell array search is string based and can/will fail when we
search for a short string that is present in a array entry as substring.

Use explicit search instead.

[note]
Also remove some debugging output.

Fixes: #918

Reported-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue Sep 8, 2022
2 tasks
@Finii
Copy link
Collaborator

Finii commented Sep 8, 2022

@Scrumplex could you test this please: https://github.com/ryanoasis/nerd-fonts/blob/bugfix-fontconfig/10-nerd-font-symbols.conf

Just fixed the obvious errors, never used a fontconfig 😬

@Finii
Copy link
Collaborator

Finii commented Sep 8, 2022

It does not make any sense to produce Symbols Nerd Font Mono, right?

$ fc-query --format='%{family}\n' ../../patched-fonts/NerdFontsSymbolsOnly/complete/Symbols*
Symbols Nerd Font Mono
Symbols NFM
Symbols Nerd Font
Symbols NF
Symbols Nerd Font Mono
Symbols NFM
Symbols Nerd Font
Symbols NF

Or does it? 🤔

Anyhow, the fontconfig prescribes the non-mono substitute.

... ?

Edit: Change formatting to make question less misunderstandable

@Scrumplex
Copy link
Author

@Scrumplex could you test this please: https://github.com/ryanoasis/nerd-fonts/blob/bugfix-fontconfig/10-nerd-font-symbols.conf

This seems to work fine 👍

@Scrumplex
Copy link
Author

I don't think we need to produce the Mono version, but I guess it doesn't hurt? Arch Linux packages both the Mono versions: https://archlinux.org/packages/?q=ttf-nerd-fonts-symbols

@Finii Finii closed this as completed in bdc28aa Sep 8, 2022
@Finii
Copy link
Collaborator

Finii commented Sep 8, 2022

I don't think we need to produce the Mono version, but I guess it doesn't hurt? Arch Linux packages both the Mono versions: https://archlinux.org/packages/?q=ttf-nerd-fonts-symbols

Where I read this ... just realized that it is a real Arch package and not an AUR, that explains something... 🤦‍♀️

If there are people who see value in that fonts... great :-) Thanks for the feedback!

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
Some (the most basic) Families are not added.

[how]
The used shell array search is string based and can/will fail when we
search for a short string that is present in a array entry as substring.

Use explicit search instead.

[note]
Also remove some debugging output.

Fixes: ryanoasis#918

Reported-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants