-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fontconfig file does not include regular Fira Code variant #918
Comments
[why] Some (the most basic) Families are not added. [how] The used shell array search is string based and can/will fail when we search for a short string that is present in a array entry as substring. Use explicit search instead. [note] Also remove some debugging output. Fixes: #918 Reported-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Scrumplex could you test this please: https://github.com/ryanoasis/nerd-fonts/blob/bugfix-fontconfig/10-nerd-font-symbols.conf Just fixed the obvious errors, never used a fontconfig 😬 |
It does not make any sense to produce
Or does it? 🤔 Anyhow, the fontconfig prescribes the non-mono substitute. ... ? Edit: Change formatting to make question less misunderstandable |
This seems to work fine 👍 |
I don't think we need to produce the Mono version, but I guess it doesn't hurt? Arch Linux packages both the Mono versions: https://archlinux.org/packages/?q=ttf-nerd-fonts-symbols |
Where I read this ... just realized that it is a real Arch package and not an AUR, that explains something... 🤦♀️ If there are people who see value in that fonts... great :-) Thanks for the feedback! |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
[why] Some (the most basic) Families are not added. [how] The used shell array search is string based and can/will fail when we search for a short string that is present in a array entry as substring. Use explicit search instead. [note] Also remove some debugging output. Fixes: ryanoasis#918 Reported-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
Since v2.2, the fontconfig file in the root of this repo doesn't include configuration for
Fira Code
(orFira Code Regular
).nerd-fonts/10-nerd-font-symbols.conf
Lines 1036 to 1051 in 5454877
Expected behavior:
Prior to v2.2, the fontconfig file in the root of this repo included configuration for
Fira Code
(orFira Code Regular
).nerd-fonts/10-nerd-font-symbols.conf
Lines 24 to 39 in fa69496
Example symbols:
N/A
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?FiraCode-Regular.ttf
(unpatched Fira Code)Symbols-2048-em Nerd Font Complete.ttf
(From AUR package, v2.2)iterm2
,urxvt
,gnome
,konsole
)?★ Screenshots (Optional)
N/A
The text was updated successfully, but these errors were encountered: