Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(font-patcher): update SymEnd codepoint for devicons font #1768

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

hasecilu
Copy link
Contributor

@hasecilu hasecilu commented Dec 22, 2024

Description

Updated SymEnd codepoint for devicons font in order to have the new icons available on Nerd Fonts.

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

Include glyphs that were left outside because a lack of update on the font-patcher script.

As you see in the devicons lib file there are some glyphs at the end that were not included on the last release.

i='' i_dev_webstorm=$i
i='' i_dev_windows11=$i
i='' i_dev_woocommerce=$i
i='' i_dev_xamarin=$i
i='' i_dev_xcode=$i
i='' i_dev_xd=$i
i='' i_dev_xml=$i
i='' i_dev_yaml=$i
i='' i_dev_yarn=$i
i='' i_dev_yugabytedb=$i
i='' i_dev_yunohost=$i
i='' i_dev_zig=$i

How should this be manually tested?

Run font-patcher.

Any background context you can provide?

I was trying to use the YAML icon but despite appearing on lib and cheat-sheet there was no icon.

What are the relevant tickets (if any)?

None

Screenshots (if appropriate or helpful)

online cheat-sheet

image

E8 on NerdFonts Symbols Only from 3.3.0 release

2024-12-22-141747_hyprshot

E7 on src/glyphs/devicons.ttf

2024-12-22-141007_hyprshot

@Finii
Copy link
Collaborator

Finii commented Dec 22, 2024

😱

In the commit ab08bd9 comment I clearly talk about 496 glyphs, but change the End only to E7E3 (from E6C5).
But E600 + 1F0 (496) - 1 = E7EF as you said.

Thank you for finding this!!

Screenshot 2024-12-22 at 23 05 35

@Finii Finii added the Bug fix label Dec 22, 2024
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii merged commit 19753b0 into ryanoasis:master Dec 22, 2024
0 of 4 checks passed
@Finii
Copy link
Collaborator

Finii commented Dec 22, 2024

Thanks again!!

I guess there might be an ordinary release in January anyhow (Monaspace for example seems to get ready for a new release), so we can tackle this and the missing font updates, and ... sigh ;)

Edit: Typo

@hasecilu
Copy link
Contributor Author

I guess there might be an ordinary release in January anyhow (Monaspace for example seems to get ready for a new release), so we can tackle this and the missing font updates, and ... sigh ;)

Great, meanwhile <> e6a8 could be used.

@Finii Finii added this to the v3.4.0 milestone Jan 14, 2025
@hasecilu hasecilu deleted the fix/devicons_end_codepoint branch March 9, 2025 23:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants