Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Remove uppercased filename for custom path #135

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

bennettdams
Copy link
Contributor

@bennettdams bennettdams commented Feb 17, 2023

This change removes toUpperCase() from the "File paths" example.

When I tried using the custom path with Next.js and my S3 policy that only allows specific extensions for images, I got "Access denied" errors. I think this is because the S3 policy is case-sensitive, so an example image abc.jpg was not working, as JPG is not allowed for my jpg policy.
I think the example is clear enough without this so maybe this helps to not confuse other developers in the future.

@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
next-s3-upload ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 10:53PM (UTC)

@ryanto
Copy link
Owner

ryanto commented Feb 17, 2023

Great find 👍

@ryanto ryanto merged commit 14106dd into ryanto:master Feb 17, 2023
@bennettdams bennettdams deleted the patch-1 branch February 22, 2023 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants