Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow anonymous user to access weekly summary #113

Merged

Conversation

rygelouv
Copy link
Owner

@rygelouv rygelouv commented Sep 17, 2024


🚀 Description

Refactor: Update ProtectedAction to support Subscribe action

This commit refactors the ProtectedAction sealed class to support the Subscribe action.

The following changes were made:

  • Added AuthRequiredAction sealed class to handle actions that require authentication, such as Save and Subscribe.
  • Added SubscriptionRequiredAction sealed class to handle actions that require a subscription, such as Listen and Read.
  • Updated ProtectedAction Interactor to handle the new Subscribe action.
  • Updated SubscriptionViewModel to check for authentication before allowing the user to subscribe.
  • Updated SummaryDetailsViewModel to use the new AuthRequiredAction.Save action.
  • Updated UI to show an authentication suggestion if the user is not authenticated and tries to subscribe.
  • Updated tests to reflect the changes.
    Issue (if applicable):

🖼 Screenshots/Videos (if applicable)

  • After:
screencapture-1726594509739.mp4

📦 Dependencies

  • Added new dependencies? List:
  • Updated existing?

🧪 Testing

Describe the steps to reproduce:

📱 Checklist

  • Tested on all supported devices and OS versions
  • UI/UX conforms to project design guidelines
  • Unit/integration tests added
  • Relevant documentation updated (e.g., README, Wiki, etc.)
  • Checked linter on local.

@rygelouv rygelouv added enhancement New feature or request new feature When adding a new feature labels Sep 17, 2024
@rygelouv rygelouv added this to the 1.2.0 milestone Sep 17, 2024
@rygelouv rygelouv self-assigned this Sep 17, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR automatically approved by auto-approve-action

Copy link

@rygelouv rygelouv merged commit 72de725 into dev Sep 17, 2024
2 of 3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request new feature When adding a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant