Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Air Quality Monitor: New property "time_state" added #187

Merged
merged 3 commits into from
Jan 28, 2018

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jan 28, 2018

No description provided.

@@ -56,3 +57,4 @@ def test_status(self):
assert self.state().aqi == self.device.start_state["aqi"]
assert self.state().battery == self.device.start_state["battery"]
assert self.state().usb_power == (self.device.start_state["usb_state"] == 'on')
assert self.state().time_state == self.device.start_state["time_state"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -10,7 +10,8 @@ def __init__(self, *args, **kwargs):
'power': 'on',
'aqi': 34,
'battery': 100,
'usb_state': 'off'
'usb_state': 'off',
'time_state' : 'format unknown'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace before ':'

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 66.243% when pulling b15ac5c on syssi:feature/airquality-monitor-updates into e861c3a on rytilahti:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 66.243% when pulling b15ac5c on syssi:feature/airquality-monitor-updates into e861c3a on rytilahti:master.

@coveralls
Copy link

coveralls commented Jan 28, 2018

Coverage Status

Coverage increased (+0.01%) to 66.243% when pulling 7c7378c on syssi:feature/airquality-monitor-updates into e861c3a on rytilahti:master.

@syssi syssi force-pushed the feature/airquality-monitor-updates branch from 670b292 to b15ac5c Compare January 28, 2018 09:53
@syssi syssi merged commit 9ebe485 into rytilahti:master Jan 28, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants