-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update dreamevacuum_miot.py with Xaiomi X10 #1924
Open
MaciekIzdebski
wants to merge
7
commits into
rytilahti:master
Choose a base branch
from
MaciekIzdebski:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−6
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c6ad2e0
Update dreamevacuum_miot.py with Xaiomi X10
MaciekIzdebski 0e9be5e
Update dreamevacuum_miot.py
MaciekIzdebski ba2e99b
Update dreamevacuum_miot.py
MaciekIzdebski 4761561
Update dreamevacuum_miot.py
MaciekIzdebski 62818fb
Update dreamevacuum_miot.py
MaciekIzdebski f5aaca0
Update dreamevacuum_miot.py
MaciekIzdebski 486e929
Added suggested fixes
MaciekIzdebski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add descriptors to the status class(es) (
@sensor
,@setting
,@action
) so we can get rid of the manual output formatting altogether, and use the standardized interface for controls (i.e., miiocli commands likestatus
,actions
,settings
,call
andset
).This makes them visible for the cli and the future homeassistant integration (https://github.com/rytilahti/homeassistant-xiaomi-ng) when it's all done across the library.