Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop python3.8 support #1979

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Drop python3.8 support #1979

merged 3 commits into from
Oct 26, 2024

Conversation

rytilahti
Copy link
Owner

No description provided.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 92.80303% with 19 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (e88159f) to head (37779e8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
miio/devtools/simulators/miiosimulator.py 0.00% 7 Missing ⚠️
miio/devtools/simulators/miotsimulator.py 0.00% 3 Missing ⚠️
miio/devtools/pcapparser.py 0.00% 2 Missing ⚠️
...iio/integrations/lumi/gateway/devices/subdevice.py 33.33% 2 Missing ⚠️
miio/integrations/roborock/vacuum/vacuum.py 77.77% 2 Missing ⚠️
miio/discovery.py 66.66% 1 Missing ⚠️
...io/integrations/chuangmi/camera/chuangmi_camera.py 66.66% 1 Missing ⚠️
miio/miioprotocol.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1979      +/-   ##
==========================================
+ Coverage   81.63%   82.23%   +0.59%     
==========================================
  Files         197      197              
  Lines       19134    19127       -7     
  Branches     4209     1050    -3159     
==========================================
+ Hits        15620    15729     +109     
- Misses       3216     3220       +4     
+ Partials      298      178     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti
Copy link
Owner Author

The py3.13 tests fail due to a regression (python/cpython#125316) that is going to be fixed in a newer 3.13 release, so ignoring this for now.

@rytilahti rytilahti merged commit 2dc6faf into master Oct 26, 2024
21 of 25 checks passed
@rytilahti rytilahti deleted the janitor/drop_py38 branch October 26, 2024 23:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant