Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide the mac address as property of the device info #260

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Mar 9, 2018

I want to use the mac address as unique_id at home assistant.

@syssi syssi added this to the 0.3.8 milestone Mar 9, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 68.267% when pulling 3a32545 on syssi:feature/device-info-mac into 2bd059c on rytilahti:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 68.267% when pulling 3a32545 on syssi:feature/device-info-mac into 2bd059c on rytilahti:master.

@syssi syssi merged commit 0aa7af6 into rytilahti:master Mar 9, 2018
@@ -95,6 +95,12 @@ def hardware_version(self) -> Optional[str]:
return self.data["hw_ver"]
return None

def mac_address(self) -> Optional[str]:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better if this would also be a property like the rest of them?

@syssi
Copy link
Collaborator Author

syssi commented Mar 10, 2018

Sure! It was too late for me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants