Air Humidifier: Strong mode property added and docstrings updated #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 13, 2018
| @@ -90,6 +119,11 @@ def test_status(self): | |||
| assert self.state().hardware_version == self.device.start_state["hw_version"] | |||
| assert self.state().button_pressed == self.device.start_state["button_pressed"] | |||
|
|
|||
| assert self.state().firmware_version == device_info.firmware_version | |||
| assert self.state().firmware_version_major == device_info.firmware_version.rsplit('_', 1)[0] | |||
| assert self.state().firmware_version_minor == int(device_info.firmware_version.rsplit('_', 1)[1]) | |||
There was a problem hiding this comment.
line too long (105 > 100 characters)
| 'cfg_time': 0, | ||
| 'life': 575661, | ||
| 'ap': {'rssi': -35, 'ssid': 'ap', | ||
| 'bssid': 'FF:FF:FF:FF:FF:FF'}, |
There was a problem hiding this comment.
continuation line under-indented for visual indent
syssi
changed the title
|
Is this ready to be merged? :-) |
|
I've concerns with this PR. The improvement is tiny and the risk to break the humidifier support is high. I will try to do some synthetic testing against my Air Purifier to be sure. |
syssi
changed the title
syssi
changed the title
|
The PR works as expected. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.