-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Xiaomi vacuum. Add property for water box (water tank) attach status #675
Conversation
@rytilahti please check this small PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor changes needed, thanks for the PR! 👍
Co-Authored-By: Teemu R. <tpr@iki.fi>
Co-Authored-By: Teemu R. <tpr@iki.fi>
@rytilahti Cool! Offtopic: Maybe there's some chat about this project? Discord / Telegram / whatever? |
There is no real release plan, we just do it after some number of changes / when it seems to be worth to due for downstreams (mainly homeassistant, I suppose). I think I'll prepare a new release after #651 gets merged, then all currently active PRs are in. What's the problem with fan speed setting? Is it the one that will get fixed when 0.109 gets released (differing fan speeds on different vacuums)? There is no chat for the project, but I'm available with the same handle on discord. |
@rytilahti Yep looks like this one. Fixed it fro now with passing direct fan values like 104 to service call. Looks like Discord links users to chats. So I can't find you only by username :( can you make chat for this project and post link? |
I created a matrix room (assuming the link is working correctly): https://matrix.to/#/#python-miio-chat:matrix.org - I might add that to the README file to see if there's interest in such, it could be handy for real-time conversations (debugging, ..) :-) |
@rytilahti ok) But it seems that group is private and invite only :) I got error "You are not invited to this room." |
@ckesc it should work now, I hope! |
…ytilahti#675) * Add property for water box (water tank) attach status * Add test for "is_water_box_attached" * Update doc * Avoid crash if vaccum doesn't support water box Co-Authored-By: Teemu R. <tpr@iki.fi> * Fix return type of is_water_box_attached Co-Authored-By: Teemu R. <tpr@iki.fi> Co-authored-by: Teemu R. <tpr@iki.fi>
No description provided.