Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Xiaomi vacuum. Add property for water box (water tank) attach status #675

Merged
merged 5 commits into from
Apr 19, 2020

Conversation

ckesc
Copy link
Contributor

@ckesc ckesc commented Apr 19, 2020

No description provided.

@coveralls
Copy link

coveralls commented Apr 19, 2020

Coverage Status

Coverage increased (+0.01%) to 73.62% when pulling 7b6360a on ckesc:water-box into 8f16c1b on rytilahti:master.

@ckesc
Copy link
Contributor Author

ckesc commented Apr 19, 2020

@rytilahti please check this small PR :)

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor changes needed, thanks for the PR! 👍

ckesc and others added 3 commits April 19, 2020 16:46
Co-Authored-By: Teemu R. <tpr@iki.fi>
Co-Authored-By: Teemu R. <tpr@iki.fi>
@ckesc ckesc requested a review from rytilahti April 19, 2020 13:48
@rytilahti rytilahti merged commit fab9e14 into rytilahti:master Apr 19, 2020
@ckesc ckesc deleted the water-box branch April 19, 2020 14:57
@ckesc
Copy link
Contributor Author

ckesc commented Apr 19, 2020

@rytilahti Cool!
BTW when will be release? Looking forward for this fix and fix from master about set_fan_speed. Currently HomeAssistant can't set fan mode except Medium :( But master version of miio can :)

Offtopic: Maybe there's some chat about this project? Discord / Telegram / whatever?

@rytilahti
Copy link
Owner

rytilahti commented Apr 19, 2020

There is no real release plan, we just do it after some number of changes / when it seems to be worth to due for downstreams (mainly homeassistant, I suppose). I think I'll prepare a new release after #651 gets merged, then all currently active PRs are in.

What's the problem with fan speed setting? Is it the one that will get fixed when 0.109 gets released (differing fan speeds on different vacuums)?

There is no chat for the project, but I'm available with the same handle on discord.

@ckesc
Copy link
Contributor Author

ckesc commented Apr 19, 2020

@rytilahti Yep looks like this one. Fixed it fro now with passing direct fan values like 104 to service call.

Looks like Discord links users to chats. So I can't find you only by username :( can you make chat for this project and post link?

@rytilahti
Copy link
Owner

rytilahti commented Apr 19, 2020

I created a matrix room (assuming the link is working correctly): https://matrix.to/#/#python-miio-chat:matrix.org - I might add that to the README file to see if there's interest in such, it could be handy for real-time conversations (debugging, ..) :-)

@ckesc
Copy link
Contributor Author

ckesc commented Apr 19, 2020

@rytilahti ok) But it seems that group is private and invite only :) I got error "You are not invited to this room."

@rytilahti
Copy link
Owner

@ckesc it should work now, I hope!

xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
…ytilahti#675)

* Add property for water box (water tank) attach status

* Add test for "is_water_box_attached"

* Update doc

* Avoid crash if vaccum doesn't support water box

Co-Authored-By: Teemu R. <tpr@iki.fi>

* Fix return type of is_water_box_attached

Co-Authored-By: Teemu R. <tpr@iki.fi>

Co-authored-by: Teemu R. <tpr@iki.fi>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants