Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

prevent errors on "lumi.gateway.mieu01" #732

Merged
merged 10 commits into from
Jun 26, 2020

Conversation

starkillerOG
Copy link
Contributor

see discussion in #728

@coveralls
Copy link

coveralls commented Jun 16, 2020

Coverage Status

Coverage decreased (-0.3%) to 73.988% when pulling a6374fd on starkillerOG:patch-11 into b0a28f0 on rytilahti:master.

@starkillerOG
Copy link
Contributor Author

@rytilahti can you also merge this?
All tests pass (except coverage)

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes needed before this can be merged.

starkillerOG and others added 3 commits June 21, 2020 08:12
Co-authored-by: Teemu R. <tpr@iki.fi>
@starkillerOG
Copy link
Contributor Author

@rytilahti thanks for your feedback!
I think this is now ready to merge.

@rytilahti rytilahti merged commit 4ded5b2 into rytilahti:master Jun 26, 2020
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
* prevent errors on "lumi.gateway.mieu01"

* add voltage and better support "lumi.gateway.mieu01"

* styling

* fix isort

* Update comments

Co-authored-by: Teemu R. <tpr@iki.fi>

* add log message

* fix black

* add gateway model constants

* black formatting

* change info to warning log

Co-authored-by: Teemu R. <tpr@iki.fi>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants