Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Export MiotDevice for miio module #876

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Export MiotDevice for miio module #876

merged 1 commit into from
Nov 30, 2020

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Nov 30, 2020 •
edited
Loading

Is there a rule for adding classes to the __init__.py?

@rytilahti
Copy link
Owner

There is no clear rule at the moment, except that it should be useful for a library user alone (so e.g., status containers are out of the picture). MiotDevice is useful to have there, as the miot_info (#672) and maybe other helper methods can be useful by themselves.

@rytilahti rytilahti changed the title Make MiotDevice available Export MiotDevice for miio module Nov 30, 2020
@rytilahti rytilahti merged commit a60917e into rytilahti:master Nov 30, 2020
@rytilahti rytilahti mentioned this pull request Mar 13, 2021
Merged
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@syssi @xvlady
Export MiotDevice for miio module (rytilahti#876)
ccf9735
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syssi @rytilahti