-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
vacuum: skip pausing on s50 and s6 maxv before return home call #933
Conversation
Just checked out locally and tested. |
This can be implemented too for s50? Mine also pauses first on a return home command |
@pergolafabio added, thanks for reporting! edit: question: did it ever work previously, or is this a change in newer firmware versions? |
np, i dont know how long the issue was |
I cannot tell neither since when it happened, I've just begun to use this integration... |
@rytilahti Hello, any news on when this will get merged? |
Thanks for the reminder, let's get this merged! I'm not sure why tests are failing (no logs available), nor can I restart them, but that can be fixed in another PR. |
Could you possibly add the S6 versioin to this? just did a test and works without "app_pause" |
Ive also noticed that if I start a segment clean while the vacuum is already cleaning then it just stops and doesn't do the segment clean, I assume this issue is the same the other way around but I havent tried that. I had put a conditional check whether the vacuum is idle or docked and if not, then stop first and wait 3 seconds then start the segment clean which works for me |
Hi i am running home assistant, seems when i do a return command when its cleaning, its still in pause state? according to components, 0.5.5 is loaded in HA? why is it still pausing? |
@Sian-Lee-SA feel free to open a new issue (or a PR to add the S6 to https://github.com/rytilahti/python-miio/blob/master/miio/vacuum.py#L153)! The segment cleaning sounds like a separate issue, so please open another one for that. @pergolafabio please open a new issue on that, and include the model information to the report. There are several different vacuums that may behave differently than the one I have used in development (gen1, old firmware). I'm now closing this issue for discussion, it makes no sense to pollute this already merged PR for issues. |
Adds a blacklist of vacuums that should not get a
app_pause
priorapp_charge
call.Fixes #918