Philips Eyecare: More safety property mapping of the device status #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 21, 2017
miio/philips_eyecare.py
Outdated
| "count (%s) of received values.", | ||
| properties_count, values_count) | ||
|
|
||
| return PhilipsEyecareStatus(defaultdict(lambda: None, zip(properties, values))) |
There was a problem hiding this comment.
line too long (87 > 79 characters)
|
Can you also add typing hints while you are at it? Otherwise it looks fine for me. |
|
Sure! |
houndci-bot
reviewed
Oct 21, 2017
miio/philips_eyecare.py
Outdated
| @@ -61,7 +65,7 @@ def set_ambient_brightness(self, level: int): | |||
| """Set Ambient Light brightness level.""" | |||
| return self.send("set_amb_bright", [level]) | |||
|
|
|||
| def status(self): | |||
| def status(self) -> PhilipsEyecareStatus: | |||
There was a problem hiding this comment.
undefined name 'PhilipsEyecareStatus'
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.