Move hardcoded parameter max_properties
#981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syssi
approved these changes
Mar 21, 2021
rytilahti
reviewed
Mar 21, 2021
|
Yes. This is a temporary workaround. I used to use this method to determine whether the device is miot or miio. Both of them has miot-spec, but only miot devices works with it in LAN. I have thought a return code -9999 indicates that they are not miot, but recently found that some devices limit max_properties to a lower value and also returns -9999 when exceeded. |
rytilahti
reviewed
Mar 23, 2021
Co-authored-by: Teemu R. <tpr@iki.fi>
1. Fix `MIoT` capitalization according to https://iot.mi.com/new/doc/design/spec/overall 2. Update `Home Assistant support` according to rytilahti#982 (comment)
Merged
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* Move hardcoded parameter `max_properties` * Update miio/miot_device.py Co-authored-by: Teemu R. <tpr@iki.fi> * Update README.rst 1. Fix `MIoT` capitalization according to https://iot.mi.com/new/doc/design/spec/overall 2. Update `Home Assistant support` according to rytilahti#982 (comment) Co-authored-by: Teemu R. <tpr@iki.fi>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all devices limit max_properties to 15. We could make this parameter customizable.