-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Pad placement #3493
base: master
Are you sure you want to change the base?
Pad placement #3493
Conversation
Build & test reportReport for commit a31efaeddc6c0746d9d331f2948fb8ec821d73ac:
Automatically generated by sPHENIX Jenkins continuous integration |
The valgrind error is just a suppression issue (the line with the known suppressed leak has changed, will update the suppression. The tracking production crashes after printing |
Build & test reportReport for commit cdd9aff0a42f7fc7812a7e49161bae9e18b1bfb3:
Automatically generated by sPHENIX Jenkins continuous integration |
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
If there are no errors, before merging this PR TPC_FEE_CHANNEL_MAP should be updated with /sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root
TPC QA plots don’t look correct as TPC_FEE_CHANNEL_MAP (that is used in simulation/g4simulation/g4tpc/PHG4TpcDetector.cc and offline/packages/tpc/TpcCombinedRawDataUnpacker.cc) should be updated with /sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root
QA plots with the correct map can be found /sphenix/user/mitrankova/sim_qa_checks/macros/detectors/sPHENIX
_CorrectMap.root - plots with the changes from this PR, with locally updated path to the correct TPC_FEE_CHANNEL_MAP(std::string calibdir = "/sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root";) _def.root - plots with current build of core software *_WrongMap.root - plots with the changes from this PR, but with TPC_FEE_CHANNEL_MAP that is currently in CDB
TODOs (if applicable)
If there are no errors, before merging this PR TPC_FEE_CHANNEL_MAP should be updated with /sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root
Links to other PRs in macros and calibration repositories (if applicable)