Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pad placement #3493

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mitrankova
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

If there are no errors, before merging this PR TPC_FEE_CHANNEL_MAP should be updated with /sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root

TPC QA plots don’t look correct as TPC_FEE_CHANNEL_MAP (that is used in simulation/g4simulation/g4tpc/PHG4TpcDetector.cc and offline/packages/tpc/TpcCombinedRawDataUnpacker.cc) should be updated with /sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root

QA plots with the correct map can be found /sphenix/user/mitrankova/sim_qa_checks/macros/detectors/sPHENIX
_CorrectMap.root - plots with the changes from this PR, with locally updated path to the correct TPC_FEE_CHANNEL_MAP(std::string calibdir = "/sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root";)
_def.root - plots with current build of core software
*_WrongMap.root - plots with the changes from this PR, but with TPC_FEE_CHANNEL_MAP that is currently in CDB

TODOs (if applicable)

If there are no errors, before merging this PR TPC_FEE_CHANNEL_MAP should be updated with /sphenix/user/mitrankova/PadPlane_Readout/map/TPCPadPlaneCDBTTree.root

Links to other PRs in macros and calibration repositories (if applicable)

@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit 79ce572560c34061528a354ea9bdc2b3b88074b4:
Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit a31efaeddc6c0746d9d331f2948fb8ec821d73ac:
Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@pinkenburg
Copy link
Contributor

The valgrind error is just a suppression issue (the line with the known suppressed leak has changed, will update the suppression. The tracking production crashes after printing
Failed to find silicon surface for hitsetkey 66576 tmpkey 66576
which I have seen in other PRs - so likely unrelated to this one

@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit cdd9aff0a42f7fc7812a7e49161bae9e18b1bfb3:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants