-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix issues #311 and #313 #315
Conversation
src/virtual-select.js
Outdated
//Will cause text overflow in runtime and if so, the tooltip information is prepared | ||
if(Utils.willTextOverflow($valueText.parentElement, label)) | ||
{ | ||
const valueTooltipForTags = this.getTooltipAttrText(label, false, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be defined as empty, and inside the if it will have the expected value, then assigned into the valueTagHtml string, if it's empty it will add nothing, otherwise it will add the expected attribute. This way the if/else can be removed ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joselrio Don't know why but the condition was not committed. Thank you for raising that 💪🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joselrio Both changes are now committed. Thank you for the great review 🚀
This PR aims to fix two issues:
allowNewOption:true
with an empty list of options causing the search input to be disabled.What was happening
allowNewOption:true
with an empty list of options caused the search input to be disabled (this was introduced in v1.0.41):After the fix
Both are now working as expected:
Broken display of options with icons #311 - ✅
The search input is disabled when allowNewOption is set to true and the options are empty. #313 - ✅