Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added option to reset() method to control the change event trigger #322

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Apr 1, 2024

What was happening

  • The reset() method triggers the change event and causes an infinite loop when used for instance inside the change event listener. An example can be simulated in this codepen and here's what happens.
  • To replicate it:
    1. Open the dropdown and select an option
    2. Checked the components entered on an infinite loop

#320 _Issue

After the fix

  • The fix was on the method reset()

  • To replicate it:

    1. Open the dropdown and select an option
    2. Check that the options are selected and the search input is properly cleared
  • Followed the same steps above - ✅

  • Ran regression scenarios - ✅

  • Run automated tests - ✅

image

@gnbm gnbm requested a review from sa-si-dev April 1, 2024 23:48
@gnbm gnbm added the enhancement New feature or request label Apr 1, 2024
@gnbm gnbm merged commit 8992b9e into master Apr 4, 2024
@gnbm gnbm deleted the Issue320v1 branch April 23, 2024 20:38
@gnbm gnbm mentioned this pull request Apr 23, 2024
@gnbm gnbm changed the title Added option to reset() method to controll the change event trigger Added option to reset() method to control the change event trigger Apr 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants