Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: unselect notes after moving #1061

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Conversation

ZebraVogel94349
Copy link
Contributor

This fixes unselecting notes after moving them. Also this fixes a bug which caused the first click on a note after deleting selected notes to result in the note being selected instead of opened in the editor.

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ede0fc0) 36.39% compared to head (e13abfa) 36.37%.

Files Patch % Lines
lib/components/home/move_note_button.dart 0.00% 2 Missing ⚠️
lib/components/home/masonry_files.dart 0.00% 1 Missing ⚠️
lib/pages/home/browse.dart 0.00% 1 Missing ⚠️
lib/pages/home/recent_notes.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
- Coverage   36.39%   36.37%   -0.03%     
==========================================
  Files         107      107              
  Lines        8359     8364       +5     
==========================================
  Hits         3042     3042              
- Misses       5317     5322       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adil192
Copy link
Member

adil192 commented Dec 24, 2023

Thanks!

@adil192 adil192 enabled auto-merge (squash) December 24, 2023 11:59
@adil192 adil192 merged commit a7bcf50 into saber-notes:main Dec 24, 2023
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants