Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add functionality to search for notes #1137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JonaFleischmann
Copy link

@JonaFleischmann JonaFleischmann commented Feb 24, 2024

Hi, I added the functionality to search for Notes. Everything I added, I have also translated into German and English.

Closes #407
android_search
android_full
win_search
win_full

@JonaFleischmann JonaFleischmann changed the title Add functionality to search for notes feat: Add functionality to search for notes Feb 24, 2024
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 4.21053% with 91 lines in your changes are missing coverage. Please review.

Project coverage is 37.01%. Comparing base (8b1088c) to head (50ab56c).

❗ Current head 50ab56c differs from pull request most recent head 84d3ad8. Consider uploading reports for the commit 84d3ad8 to get more accurate results

Files Patch % Lines
lib/pages/home/search.dart 1.09% 90 Missing ⚠️
lib/pages/home/home.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
- Coverage   37.16%   37.01%   -0.16%     
==========================================
  Files         108      109       +1     
  Lines        8500     8592      +92     
==========================================
+ Hits         3159     3180      +21     
- Misses       5341     5412      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QubaB
Copy link
Contributor

QubaB commented Feb 16, 2025

Thank you for your code, I merged your code to my personal version of Saber.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Feature in home page
2 participants