Module refactoring

[creekorful]

Hello there!

First of all thank you for this library, it has been really useful to me!

I have done a little refactoring to turn your library into a Go module, as well as moving the code library part into pkg directory (following github.com/golang-standards/project-layout standards)

Turning the library into a Go module allow us to remove the whole vendor directory. Which is the new language way to go. See https://blog.golang.org/modules2019

The only thing is, I think it would be a good idea to increase major version, since this change would break existing codebase.

What do you think ?

P-S: It should be great to add support for Go 1.12,1.13,1.14 (by adding them in Travis config file). I can do that if you want.

[coveralls]

Coverage decreased (-5.3%) to 37.5% when pulling 2420b69 on creekorful:module-refactoring into 1f746af on sabhiram:master.

[BlackHole1]

This is great, is there any latest progress?
@sabhiram What do you think?

[sabhiram]

nit : I always try to keep non standard packages after the first set of imports - but we can deal w/ this later 👍 Thank you for this work btw!

[creekorful]

Sorry about this, I usually run gofmt over my files and it rearranges imports like this.

I can revert that if you want!

[sabhiram]

Yea if you would be kind enough to fix up travis for now - or we can move to github actions etc etc I will happily merge.

Also, we can release v2.0.0 in support of the modulization work you have done. Ill hold merging until you comment and ack this plan. Thank you again for the work and I am sorry I didnt see this till just now.

[creekorful]

Hey @sabhiram !

Yea if you would be kind enough to fix up travis for now - or we can move to github actions etc etc I will happily merge.

Sure no problem. If you consider the move to Github Action then I'll do the change in the same PR!

Also, we can release v2.0.0 in support of the modulization work you have done. Ill hold merging until you comment and ack this plan.

I'll just do a little change: the pkg folder I have created is in fact not a good practice anymore (see here).
So I'll move files in root directory.

Thank you again for the work and I am sorry I didnt see this till just now.

No problem at all!

Cheers,

[creekorful]

Hey back @sabhiram,
I have push another commit to move everything out of pkg folder (bad practice).

Regarding Github Action migration, I've noticed that your pipeline does a lot of stuff, and therefore I prefer doing the change in another PR to not bloat this one more.

Is that okay for you?

Cheers,

[sabhiram]

Ya totally fine by me, thank you for helping!