Fix bug in by year day #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=========================================
Coverage 98.35% 98.35%
Complexity 1897 1897
=========================================
Files 71 71
Lines 4549 4550 +1
=========================================
+ Hits 4474 4475 +1
Misses 75 75
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phil-davis
commented
Aug 17, 2022
Comment on lines
+594
to
+595
| '2020-07-08 14:53:11', | ||
| '2020-10-27 14:53:11', |
There was a problem hiding this comment.
Note for future readers: 202 was a leap year, so day 60 was 29 Feb. In other years, day 60 is 1 Mar. So day 190 and day 301 in a leap year are 2020-07-08 and 2020-10-27 (a day earlier in those months)
This is correct, and so this test (and some other tests) have cases in the output that verify that leap-year counting is happening.
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #436