Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ITip\Broker: handle timezones in replies to exception events #652

Merged
merged 3 commits into from
May 9, 2024

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented May 8, 2024

fixes #358, closes #360

While rebasing #360, I noticed that it only fixes replies to new exception events. I use a different approach now, which also fixes replies to existing exception events.

Co-authored-by: Luc DUZAN <lduzan@linagora.com>
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (f14092f) to head (bee4fa7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #652   +/-   ##
=========================================
  Coverage     98.78%   98.78%           
- Complexity     1866     1868    +2     
=========================================
  Files            71       71           
  Lines          5249     5253    +4     
=========================================
+ Hits           5185     5189    +4     
  Misses           64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis self-requested a review May 8, 2024 09:36
@phil-davis phil-davis requested review from staabm and phil-davis May 8, 2024 09:50
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this solution is cleaner than the original solution from #360

@staabm can you also review please.

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see obvious problems

@phil-davis phil-davis merged commit d4bf35b into sabre-io:master May 9, 2024
8 checks passed
@gharlan gharlan deleted the recurrence-id-timezone branch May 9, 2024 12:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker::processMessageReply
3 participants