Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Replace dirname(__FILE__) with __DIR__ #675

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ChristophWurst
Copy link
Contributor

🧹

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (57492ab) to head (3bfeaee).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #675      +/-   ##
============================================
+ Coverage     98.76%   98.78%   +0.02%     
  Complexity     1874     1874              
============================================
  Files            71       71              
  Lines          5343     5270      -73     
============================================
- Hits           5277     5206      -71     
+ Misses           66       64       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"something happened" with the CI for PHP 8.0.
I reran it and it passes.

@phil-davis phil-davis merged commit c532bfc into sabre-io:master Oct 14, 2024
8 checks passed
@phil-davis
Copy link
Contributor

Note: tests only, this does not trigger a need to release.

@phil-davis
Copy link
Contributor

Backported to 4.5 branch in PR #693

@ChristophWurst ChristophWurst deleted the refactor/dirname-to-dir branch October 14, 2024 03:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants