Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(tx-builder): autocomplete for contract method #809

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

katspaugh
Copy link
Member

What it solves

A user complained that a select offers a subpar UX when searching for a method name.

How this PR fixes it

Replaces the Select component with an input with Autocomplete.

How to test it

  • Open Transaction Builder
  • Enter a contract address with many methods
  • Type the first letters of the method name

Screenshots

Screenshot 2024-08-09 at 16 36 05

@katspaugh katspaugh requested a review from usame-algan August 9, 2024 14:37
@katspaugh katspaugh marked this pull request as draft August 9, 2024 14:55
@katspaugh
Copy link
Member Author

Need to fix unit tests.

@katspaugh katspaugh marked this pull request as ready for review August 19, 2024 10:23
@katspaugh katspaugh removed the request for review from usame-algan August 19, 2024 10:24
@francovenica
Copy link

I tried to add the safe app as a custom one in dev with prod and stg cgw, in different networks but it always fails.
image

@katspaugh
Copy link
Member Author

Try opening some other app and replace the appUrl part.

@francovenica
Copy link

Yeah, that worked.
LGTM

@katspaugh katspaugh merged commit 012f1f7 into development Aug 20, 2024
6 of 7 checks passed
@katspaugh katspaugh deleted the tx-b-auto branch August 20, 2024 05:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants